FIX TreeDropdownField doesnt change label on unselect #4272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs merging into 3 branch too |
| if(title) { | ||
| self.setTitle(title); | ||
| self.data('title', title); | ||
| } | ||
| if(node) tree.jstree('select_node', node); | ||
| } | ||
| else { | ||
| self.setTitle(self.data('empty-title')); |
There was a problem hiding this comment.
self.data('emptyTitle')
There was a problem hiding this comment.
Either will work, if you do camelCase then jQuery will look for the camelCase then the dash-separated names. So it's actually more performant this way
The native JS data API requires camelCase, though.
I can change it, but it's ultimately not going to change the behaviour and be fractionally slower
tractorcow
pushed a commit
that referenced
this pull request
Jun 14, 2015
FIX TreeDropdownField doesnt change label on unselect
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a front-end regression in the CMS where changing a drop down to an unselected value appeared to make no difference:
Before:
After:
