Allow shortcodes inside script tags. Fixes #4332. #4333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Upon reflection, it might be better to take a different approach with this, and instead only transform shortcodes if thet have a shortcode parser actually registered. Has this been discussed before? |
added 2 commits
June 22, 2015 11:29
The problem is that the marker images aren’t picked up by DOMDocument if they are inserted into a <script> tag, due to the semantics of HTML. This fix does an additional replacement after the marker images are replaced in this way to pick up any leftover tags.
error_behaviour = self::LEAVE is the default behaviour. In this case, we don’t even need to bother recognising such tags. Rather than replacing with marker images and re-inserting the original text after we’re done, we can leave them alone. This should make the code faster and more reliable.
|
OK, I take back my previous comments. It has been discussed before, and implemented. The actual bug here was to do with <script> tags. Fix pushed and, since it's a low-risk bugfix, should be okay for 3.1. |
sminnee
changed the title
hafriedlander
pushed a commit
that referenced
this pull request
Jun 25, 2015
Allow shortcodes inside script tags. Fixes #4332.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will ensure that short tagnames have to start with a letter or _, rather than starting with a number. This stops '[2]' from being a legal shortcode.
Although this is one way of fixing the bug identified in 4332, it would be good to confirm whether it is the best fix.