FIX: Using undefined var in ModelAdmin #4508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Classic! |
dhensby
added a commit
that referenced
this pull request
Aug 18, 2015
FIX: Using undefined var in ModelAdmin
|
This was my fault, sorry. I merged a PR with a bug; the relevant code in ModelAdmin wasn't covered by a test. |
|
No worries @sminnee. We need to get better at checking scrutinizr (and have it fail on these kinds of things). I was more commenting that I merged a big up to all branches, than the fact we pulled in a bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #4477.
$classNameis undefined. Figured we may as well usesanitiseClassName()too as that’s what the method was added for.ping @dhensby as you’ve been merging upstream lately. Looks like this is an issue across 3.1, 3.2, 3 and master. Good luck! 😜