Fix mysql decimal and enum default sql #4650
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
decimal has and extra space before 'default' and enum was quoting digit only default. Both were causing 'changes' in /dev/build that weren't doing anything.
|
Nice fix, but I'm surprised by the way that enum is treating numeric values. Is this because Please include the php you are using to generate this enum so I can test it locally. I am extremely hesitant to admit that sometimes it's safe to not quote a sql string. :) |
|
@mikenz @tractorcow are we able to nudge this one along? |
|
Fixed for me, likely in #4731 |
|
Sorry I didn't get to this in time. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
decimal has and extra space before 'default' and wasn't quoted.
enum was quoting digit only defaults unnecessarily . Both were causing 'changes' in /dev/build that weren't doing anything.