DOCS 3.0 : eliminate hard coded numbers in tutorial labels & links #4808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 29, 2015
SpiritLevel
changed the title
|
ping @camfindlay |
|
@dhensby this looks good to merge. |
|
@camfindlay the files have been renamed so they don't have the 01_, 02_, etc prefix. Are we not doing this anymore? I thought they were removed in the URLs anyway. |
|
@tractorcow this is an old version before we moved to that convention. The prefixes here were to pseudo do in an old version of docsviewer what the new version does now for sorting. |
|
Oh, I see. |
tractorcow
pushed a commit
that referenced
this pull request
Dec 21, 2015
DOCS 3.0 : eliminate hard coded numbers in tutorial labels & links
|
Thanks...@tractorcow more coming for 3.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes hard coded numbers as well as fixes internal links, with the aim of eliminating .htaccess rewrite rules for doc.silverstripe.org (as part of a tidy up of the rewrite rules there). Note that gurlchecker was used to identify broken internal links. Also note that multiple PRs will likely result since different doc versions have different internal link problems.