Commits on May 23, 2012

1. BUGFIX Versioned's constructor doesn't provide suitable defaults. Pre… …

   …viously a bug/feature in singleton, where it would pass null,true as params to strong_create, which would then get passed through as params to Versioned's constructor, meant that the code still executed fine (as was set to something that wasn't an array, so the null and true were instead taken as args). The fact that the usage of singleton(Versioned) never really used the classes code, purely for value lookup, meant that this never propagated errors. I've now switched singleton() to use the injector for retrieving values, which means these dud values are no longer passed through
   
   CHANGE Given that Config::inst is an implementation of the singleton pattern itself, I've removed the extra call to singleton(). A side effect of this is that it gets around a possibly nasty circular reference with the dependency injector (which relies on the config object); in future, this dependency structure should really be structured from the DI directly.
   
   MINOR Change singleton and strong_create to use dependency injector
   
   BUGFIX: Provide default constructor values for classes (fixes issues when used in 'singleton' scenario during dev/build in particular)
   
   MINOR Clear out injector state when resetting db schema during tests (a follow on from changing singleton() calls to use the injector underneath)

   Marcus Nyeholt committed May 23, 2012
   Configuration menu

   • View commit details
   • Copy full SHA for 82495f5
   • Browse repository at this point

   Copy the full SHA

   82495f5 View commit details

   Browse the repository at this point in the history