-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove $CleartextPassword from ChangePasswordEmail.ss #5221
Conversation
Line 5 really needs changing as it doesn't show the credentials any more, just email This should probably just say something like "The password for account with email address $Email has been changed. If you didn't change your email please change your password (link to password reset form) urgently" |
5daf1dc
to
f3fe606
Compare
updated CHANGEPASSWORDTEXT2 with your suggestion and removed the output of Email on line 9 as it's now in the text of CHANGEPASSWORDTEXT2 |
Maybe easier with translations to say "using the link below" then include a link to |
f3fe606
to
db821e7
Compare
I think it's probably fine; If you're using a custom field, you can also just as easily add a custom template too. |
<p> | ||
<%t ChangePasswordEmail_ss.EMAIL 'Email' %>: $Email<br /> | ||
<%t ChangePasswordEmail_ss.PASSWORD 'Password' %>: $CleartextPassword | ||
<%t ChangePasswordEmail_ss.CHANGEPASSWORDTEXT2 'The password for account with email address {email} has been changed. If you didn't change your password please change your password using the link below' email=$Email %><br /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't re-define translation strings re-using old keys; You'll need to create a new translation string instead.
All translations are shared across all versions, so this would cause this string to appear on all 3.x releases, unfortunately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops, my bad.
One more problem to fix please. :) |
ChangePasswordEmail.ss 4.x version of silverstripe#5194
db821e7
to
ceccd95
Compare
Good point. All done :-) |
4.x version of #5194