Add AddToCampaign dialog box functionality #5368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also see silverstripe/silverstripe-cms#1459 |
hafriedlander
force-pushed
the
pulls/4.0/add-to-campaign
branch
2 times, most recently
from
555bf04
to
a4437fa
Compare
| * Add to campaign dialog | ||
| * -------------------------------------------- */ | ||
|
|
||
| #add-to-campaign__dialog { |
There was a problem hiding this comment.
We shouldn't be using ID selectors in CSS.
|
I'm going to stop reviewing and just push up phpdoc fixes. :D |
|
|
||
| $fields = new FieldList([$campaignDropdown]); | ||
|
|
||
| foreach ($this->data as $k => $v) { |
There was a problem hiding this comment.
I thought you were going to change this? I'm still getting array to string conversion when pushing data that is nested array content.
There was a problem hiding this comment.
You can change this to a recursive walk (probably in another method) that knows how to reconstruct a set of Name[Field] hiddenfields for each nested array.
tractorcow
force-pushed
the
pulls/4.0/add-to-campaign
branch
from
7ca1e31
to
75b23e5
Compare
hafriedlander
force-pushed
the
pulls/4.0/add-to-campaign
branch
from
75b23e5
to
97e6727
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.