Fix loading icon bug on IE #5460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scott1702
force-pushed
the
btn-loading-icon
branch
3 times, most recently
from
42e9818
to
d33e3c4
Compare
|
@scott1702 This hasn't been tested with other button style variations I think, the dots are grey regardless of the button text colour (cc @clarkepaul)
|
scott1702
force-pushed
the
btn-loading-icon
branch
3 times, most recently
from
ba6925a
to
67e2e37
Compare
|
Should be good now @chillu |
|
Broken up in two lines for IE10 on "Edit Campaign": http://take.ms/8rzqa |
scott1702
force-pushed
the
btn-loading-icon
branch
from
67e2e37
to
1ac5bbe
Compare
|
Talked this over with @clarkepaul around how we could handle this, came to the decision of using the same indicator with smaller circles. This change has been added and tested with buttons as small as 'icon-only'. Third time lucky @chillu? 😉 |
|
Looked good to me and tested in IE10. |
scott1702
force-pushed
the
btn-loading-icon
branch
from
1ac5bbe
to
7f0bfc2
Compare
| } | ||
|
|
||
| .btn-danger { | ||
| .btn__circle { |
There was a problem hiding this comment.
you're not meant to nest elements in BEM
ergh, ignore me this is inside a bootstrap type modified
|
needs rebasing :/ |
scott1702
force-pushed
the
btn-loading-icon
branch
from
7f0bfc2
to
9ba3620
Compare
|
Rebased :) |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately IE can't handle css animating SVGs, this just turns the into s so we can animate them in IE.
Fixes #5283