Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX add_i18n_javascript calls not being updated after JS move #5475

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .tx/config
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,13 @@ source_lang = en
type = YML

[silverstripe-framework.master-js]
file_filter = javascript/lang/src/<lang>.js
source_file = javascript/lang/src/en.js
file_filter = client/lang/src/<lang>.js
source_file = client/lang/src/en.js
source_lang = en
type = KEYVALUEJSON

[silverstripe-framework.master-admin-js]
file_filter = admin/javascript/lang/src/<lang>.js
source_file = admin/javascript/lang/src/en.js
file_filter = admin/client/lang/src/<lang>.js
source_file = admin/client/lang/src/en.js
source_lang = en
type = KEYVALUEJSON
2 changes: 1 addition & 1 deletion admin/code/LeftAndMain.php
Original file line number Diff line number Diff line change
Expand Up @@ -510,7 +510,7 @@ public function init() {
]
]);

Requirements::add_i18n_javascript(FRAMEWORK_DIR . '/javascript/lang', false, true);
Requirements::add_i18n_javascript(FRAMEWORK_DIR . '/client/lang', false, true);
Requirements::add_i18n_javascript(FRAMEWORK_ADMIN_DIR . '/client/lang', false, true);

if ($this->config()->session_keepalive_ping) {
Expand Down
2 changes: 2 additions & 0 deletions docs/en/04_Changelogs/4.0.0.md
Original file line number Diff line number Diff line change
Expand Up @@ -133,11 +133,13 @@ Care should also be taken when referencing images in these folders from your own

```
framework/javascript => framework/client/dist/
framework/javascript/lang => framework/client/lang/
framework/images => framework/client/dist/images/
framework/css => framework/client/dist/css/
framework/scss => framework/client/src/styles/
admin/javascript/ => admin/client/src/
admin/javascript/src/ => admin/client/src/legacy/ (mostly)
admin/javascript/lang/ => admin/client/lang/
admin/scss/ => admin/client/styles/legacy/
admin/css/ => admin/client/dist/css/
admin/css/screen.css => admin/client/dist/css/bundle.css
Expand Down
2 changes: 1 addition & 1 deletion forms/AssetField.php
Original file line number Diff line number Diff line change
Expand Up @@ -493,7 +493,7 @@ public function Field($properties = array()) {
Requirements::javascript(THIRDPARTY_DIR . '/jquery-ui/jquery-ui.js');
Requirements::javascript(THIRDPARTY_DIR . '/jquery-entwine/dist/jquery.entwine-dist.js');
Requirements::javascript(FRAMEWORK_ADMIN_DIR . '/client/dist/js/ssui.core.js');
Requirements::add_i18n_javascript(FRAMEWORK_DIR . '/javascript/lang');
Requirements::add_i18n_javascript(FRAMEWORK_DIR . '/client/lang');

Requirements::combine_files('uploadfield.js', array(
// @todo jquery templates is a project no longer maintained and should be retired at some point.
Expand Down
2 changes: 1 addition & 1 deletion forms/TreeDropdownField.php
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ public function setNumChildrenMethod($method) {
* @return HTMLText
*/
public function Field($properties = array()) {
Requirements::add_i18n_javascript(FRAMEWORK_DIR . '/javascript/lang');
Requirements::add_i18n_javascript(FRAMEWORK_DIR . '/client/lang');

Requirements::javascript(FRAMEWORK_DIR . '/thirdparty/jquery/jquery.js');
Requirements::javascript(FRAMEWORK_DIR . '/thirdparty/jquery-entwine/dist/jquery.entwine-dist.js');
Expand Down
2 changes: 1 addition & 1 deletion forms/TreeMultiselectField.php
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ public function getItems() {
* formfield can contain multiple values.
*/
public function Field($properties = array()) {
Requirements::add_i18n_javascript(FRAMEWORK_DIR . '/javascript/lang');
Requirements::add_i18n_javascript(FRAMEWORK_DIR . '/client/lang');

Requirements::javascript(FRAMEWORK_DIR . '/thirdparty/jquery/jquery.js');
Requirements::javascript(FRAMEWORK_DIR . '/thirdparty/jquery-entwine/dist/jquery.entwine-dist.js');
Expand Down
2 changes: 1 addition & 1 deletion forms/UploadField.php
Original file line number Diff line number Diff line change
Expand Up @@ -928,7 +928,7 @@ public function Field($properties = array()) {
Requirements::javascript(THIRDPARTY_DIR . '/jquery-ui/jquery-ui.js');
Requirements::javascript(THIRDPARTY_DIR . '/jquery-entwine/dist/jquery.entwine-dist.js');
Requirements::javascript(FRAMEWORK_ADMIN_DIR . '/client/dist/js/ssui.core.js');
Requirements::add_i18n_javascript(FRAMEWORK_DIR . '/javascript/lang');
Requirements::add_i18n_javascript(FRAMEWORK_DIR . '/client/lang');

Requirements::combine_files('uploadfield.js', array(
// @todo jquery templates is a project no longer maintained and should be retired at some point.
Expand Down
2 changes: 1 addition & 1 deletion forms/gridfield/GridField.php
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,7 @@ public function FieldHolder($properties = array()) {
Requirements::javascript(THIRDPARTY_DIR . '/jquery/jquery.js');
Requirements::javascript(FRAMEWORK_DIR . '/thirdparty/jquery-ui/jquery-ui.js');
Requirements::javascript(FRAMEWORK_DIR . '/client/dist/js/i18n.js');
Requirements::add_i18n_javascript(FRAMEWORK_DIR . '/javascript/lang');
Requirements::add_i18n_javascript(FRAMEWORK_DIR . '/client/lang');
Requirements::javascript(THIRDPARTY_DIR . '/jquery-entwine/dist/jquery.entwine-dist.js');
Requirements::javascript(FRAMEWORK_DIR . '/client/dist/js/GridField.js');

Expand Down