NEW: Add Requirements_Backend.nonce_format config #5740
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This config option can be set to ‘md5’ to use nonces based on the md5-checksum of the content, rather than filemtime. This can be useful when sessions aren’t blocking (e.g. when using database-backed sessions) When sessions aren’t blocking, the CMS combined-files calls will introduce race conditions that lead to unnecessary reloads of combined files.
| @@ -1005,6 +1005,16 @@ protected function path_for_file($fileOrUrl) { | |||
| } | |||
| } | |||
|
|
|||
| protected function generateNonce($filePath) { | |||
| if(!file_exists($filePath)) return 'notfound'; | |||
There was a problem hiding this comment.
Director::fileExists already checks this above.
|
@sminnee SS4 appears to use |
|
Nah I think I'll cancel this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This config option can be set to ‘md5’ to use nonces based on the
md5-checksum of the content, rather than filemtime. This can be useful
when sessions aren’t blocking (e.g. when using database-backed sessions)
When sessions aren’t blocking, the CMS combined-files calls will
introduce race conditions that lead to unnecessary reloads of combined
files.