add async and defer attributes to js requirements, replaces #4555 #5771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test failure related, I'm afraid :( |
xini
force-pushed
the
feature-requirements-async-defer-40
branch
2 times, most recently
from
d7c94ae
to
4bacce3
Compare
|
I have fixed the PHP issue, but behat is still failing. Any ideas? Forked from a failing master? Cheers. |
|
@xini the issues seem to relate to the |
|
Try rebasing against master? |
xini
force-pushed
the
feature-requirements-async-defer-40
branch
2 times, most recently
from
82361ec
to
3352ceb
Compare
|
hm.. now the npm test fails. any ideas? |
|
Seems npm is having some issues: npm/npm#13284 |
|
Looks like the codeclimate issues need to be sorted out now |
|
the codeclimate issue is not something I can fix. it's a +/-2 of the same issue in hoverintent.js. nothing to do with this PR. same in #5777. |
|
@xini can you try rebasing, please, as that PR you referenced has now passed all tests |
xini
force-pushed
the
feature-requirements-async-defer-40
branch
from
3352ceb
to
9fc51dc
Compare
|
here we go. finally. ;) Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ok. rebased and reworked.. @sminnee @chillu @dhensby