Enhancements for flexbox on smaller screens #6222
Conversation
| @@ -80,6 +80,7 @@ class FormBuilderModal extends SilverStripeComponent { | |||
| * @returns {Promise} | |||
| */ | |||
| handleSubmit(data, action, submitFn) { | |||
| console.log(data, action, submitFn); | |||
| this.handleBackClick = this.handleBackClick.bind(this); | ||
| } | ||
|
|
||
| handleBackClick(event) { |
There was a problem hiding this comment.
If onBack isn't supplied, it will just have a no-op. I think we should throw an error if onBack isn't set and the button is clicked.
Alternatively, if onBack isn't supplied, remove the back button altogether.
There was a problem hiding this comment.
@flamerohr ^ is something you can look at
There was a problem hiding this comment.
good point, I think removing the back button makes sense, gives the option of not having the back button then
clarkepaul
force-pushed
the
features/4.0/responsive-improvements
branch
from
368399e
to
a0f10c8
Compare
Fix back button in preview Fix add to campaign in pages section
clarkepaul
force-pushed
the
features/4.0/responsive-improvements
branch
from
a0f10c8
to
a5d3dcc
Compare
|
In the security section, reducing browser width removes the action button column. Perhaps it should remove all except the first / last columns?
can you make it work the same way that campaigns does? (drops from 4 columns to 2)
|
|
I don't know if this is related to the current change but the security cancel button styling is weird.
|
|
In the campaign section there is inconsistent placement for the "back" button. When previewing a page with an available preview the back button appears as this:
However if the page has no available preview, the back button appears in another place.
|
|
I've fixed the list view, will push shortly. |
|
@tractorcow In regards to showing the first and last column in grid fields, the problem is that all grid fields are composed differently so you can't always say what is first or last (eg page list has toggle first). With the Campaigns grid field I know there are two sets of actions at the end so I can show them, I also know they fit at a mobile screen size where-as other actions are sometimes accompanied by text which can break the layout. Actions are available once you select an item and go deeper so we are not removing functionality. |
clarkepaul
force-pushed
the
features/4.0/responsive-improvements
branch
from
59666c2
to
4cc6cc3
Compare
Fix FormBuilderLoader not chaining promise
|
It was a conscious decision to use text to support the back arrow in the Campaign preview because it doesn't sit next to the inner page navigation like breadcrumbs or page name. Not a big deal really if I did remove the text but I think its better to decide that when we introduce the rest of the preview editing actions and draft/publish toggle. |
Fixes #6164
Requires Framework, CMS, AssetAdmin, Site-config branches of features/4.0/responsive-improvements