Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Ensure that builds use the 3.2 dependencies. #6282

Merged
merged 1 commit into from
Nov 3, 2016
Merged

FIX: Ensure that builds use the 3.2 dependencies. #6282

merged 1 commit into from
Nov 3, 2016

Conversation

sminnee
Copy link
Member

@sminnee sminnee commented Nov 3, 2016

No description provided.

@helpfulrobot
Copy link

@sminnee, thanks for your PR! By analyzing the blame information on this pull request, I identified @chillu and @dhensby to be potential reviewers

@sminnee
Copy link
Member Author

sminnee commented Nov 3, 2016

Hold off on this one until #6283 is reviewed. We may have a simpler approach that we can cherry-pick in

FIX: Ensure that builds use the 3.4 dependencies.
edfe514 
This fix does it in a way that doesn’t need manual maintenance
per-branch
@sminnee
Copy link
Member Author

sminnee commented Nov 3, 2016

OK this is just a cherry-pick of #6283 now

@tractorcow tractorcow merged commit 182c9fb into silverstripe:3.2 Nov 3, 2016
@dhensby dhensby mentioned this pull request Nov 3, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sminnee @helpfulrobot @tractorcow