Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX Tests shouldnt set date or time format to null #6328

Merged
merged 1 commit into from Nov 23, 2016
Merged

FIX Tests shouldnt set date or time format to null #6328

merged 1 commit into from Nov 23, 2016

Conversation

dhensby
Copy link
Contributor

@dhensby dhensby commented Nov 23, 2016

This fixes a regression with tests where the date_format is expected to be non-null.

@helpfulrobot
Copy link

@dhensby, thanks for your PR! By analyzing the blame information on this pull request, I identified @chillu, @sminnee and @wilr to be potential reviewers

@tractorcow tractorcow merged commit 730512f into silverstripe:3.1 Nov 23, 2016
@dhensby dhensby deleted the pulls/3.1/test-i18n-fix branch January 16, 2018 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dhensby @helpfulrobot @tractorcow