Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Altering error message to show the exception #6391

Merged
merged 2 commits into from Jan 19, 2017
Merged

Altering error message to show the exception #6391

merged 2 commits into from Jan 19, 2017

Conversation

catharsisjelly
Copy link
Contributor

See #6390

@helpfulrobot
Copy link

@catharsisjelly, thanks for your PR! By analyzing the blame information on this pull request, I identified @assertchris, @chillu and @wilr to be potential reviewers

@tractorcow
Copy link
Contributor

It's too risky to be displaying error messages contained in exceptions outside of dev mode, as these could contain potentially sensitive information.

You can get around this with a conditional Director::isDev() ? print('explicit message') : print('simple message')

@catharsisjelly
Copy link
Contributor Author

@tractorcow Made a change based on your suggestion to this PR

@chillu chillu merged commit 61201ed into silverstripe:3.4 Jan 19, 2017
@tractorcow
Copy link
Contributor

Nice job. :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants