Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding some PHPDoc #6522

Merged
merged 1 commit into from Jan 17, 2017
Merged

Adding some PHPDoc #6522

merged 1 commit into from Jan 17, 2017

Conversation

catharsisjelly
Copy link
Contributor

No description provided.

@helpfulrobot
Copy link

@catharsisjelly, thanks for your PR! By analyzing the blame information on this pull request, I identified @chillu, @sminnee and @halkyon to be potential reviewers

@catharsisjelly catharsisjelly changed the title Adding lots of PHPDoc Adding some PHPDoc Jan 17, 2017
@dhensby dhensby merged commit 6ff9874 into silverstripe:3.4 Jan 17, 2017
@dhensby
Copy link
Contributor

dhensby commented Jan 17, 2017

thanks

@dhensby
Copy link
Contributor

dhensby commented Jan 17, 2017

FYI - worth noting this class has been completely re-written for v4 :)

@catharsisjelly
Copy link
Contributor Author

I thought that might be the case, I was going to look for it but have not had the time. Thanks for merging it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@catharsisjelly @helpfulrobot @dhensby