API Split SilverStripe\Assets into separate module #6723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 20, 2017
tractorcow
force-pushed
the
pulls/4.0/assets-module
branch
from
ef2d9bf
to
dae6d59
Compare
sminnee
requested review from
wilr,
chillu,
dhensby,
unclecheese,
flamerohr,
jonom,
kinglozzer and
stevie-mayhew
sminnee
approved these changes
Mar 21, 2017
sminnee
requested changes
Mar 21, 2017
| @@ -23,6 +23,7 @@ | |||
| "monolog/monolog": "~1.11", | |||
| "nikic/php-parser": "^2 || ^3", | |||
| "silverstripe/config": "^1@dev", | |||
| "silverstripe/assets": "^1@dev", | |||
There was a problem hiding this comment.
This should be a requirement of cms, not framework.
There was a problem hiding this comment.
OK while there's coupling still in place this is probably okay as a first step.
There was a problem hiding this comment.
Yeah, there is quite a bit of work to de-couple that at this stage. It may be closer to a 5.0 / 4.late goal. :)
sminnee
approved these changes
Mar 21, 2017
| @@ -23,6 +23,7 @@ | |||
| "monolog/monolog": "~1.11", | |||
| "nikic/php-parser": "^2 || ^3", | |||
| "silverstripe/config": "^1@dev", | |||
| "silverstripe/assets": "^1@dev", | |||
There was a problem hiding this comment.
OK while there's coupling still in place this is probably okay as a first step.
7 tasks
|
@silverstripe/core-team any objections? |
flamerohr
reviewed
Mar 21, 2017
flamerohr
approved these changes
Mar 21, 2017
stevie-mayhew
approved these changes
Mar 22, 2017
|
I feel like we've got a sufficient quorum so I'm merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/silverstripe/silverstripe-assets
Fixes #5289
Requires silverstripe/silverstripe-installer#158