Find root modules with _config.php #6903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sminnee
approved these changes
May 10, 2017
chillu
force-pushed
the
pulls/4.0/manifestfilefinder-config-file
branch
from
98919e6
to
fbd8617
Compare
tractorcow
approved these changes
May 11, 2017
|
Please fix the test and we can merge. |
|
because you can't commit an empty |
tractorcow
force-pushed
the
pulls/4.0/manifestfilefinder-config-file
branch
from
fbd8617
to
149b77d
Compare
When modules are installed as the webroot, manifest generation should behave the same way as when they're in a subfolder. Which means accepting the module folder both with a _config/ folder and a _config.php file present.
tractorcow
force-pushed
the
pulls/4.0/manifestfilefinder-config-file
branch
from
149b77d
to
ba89c08
Compare
|
Rebased; Hope this greens! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When modules are installed as the webroot,
manifest generation should behave the same way as when they're in a subfolder.
Which means accepting the module folder both with a _config/ folder
and a _config.php file present.