[WIP] Security docs and changelog updates for auth refactor. #7008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firesphere
force-pushed
the
pulls/security-docs
branch
from
b02fee3
to
bc42e5c
Compare
chillu
requested changes
Jun 28, 2017
There was a problem hiding this comment.
@Firesphere Can you please rebase this in the next 24h, and trim down the amount of upgrading guidance? We need to get the upgrading docs in there for the beta1 release, which is imminent.
| SilverStripe\Security\Authenticator; | ||
| authenticators: | ||
| - MyVendor\MyModule\MyAuthenticator | ||
| SilverStripe\Core\Injector\Injector: |
There was a problem hiding this comment.
Most of this should move to the actual security docs - it's less of an upgrade concern. The changelog is getting far too long with this stuff all inlined.
There was a problem hiding this comment.
Cool, will do asap :)
|
@Firesphere, a rebate would be better than adding a merge commit and the commits need squashing as the commit messages are not quite optimal at the moment ;) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.