[WIP] API: Don’t auto-convert update to an insert in DB::manipulate() #7073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature creates an extra SELECT on every update and its only benefit is to paper over other bugs that should be fixed with better data integrity. Fixes #7072
tractorcow
suggested changes
Jul 2, 2017
| @@ -343,12 +343,8 @@ public function manipulate($manipulation) | |||
| $query->addWhere(array('"ID"' => $writeInfo['id'])); | |||
| } | |||
|
|
|||
| // Test to see if this update query shouldn't, in fact, be an insert | |||
| if ($query->toSelect()->count()) { | |||
There was a problem hiding this comment.
This by itself isn't going to be enough. The insert logic in DataObject::write() initially writes to the base table to get the ID, and that relies on the base table insert being converted to an update here.
I thought the fix was to use affectedRows() to trigger the fallback to update?
There was a problem hiding this comment.
affectedRows() seems to return false if you run an update query that doesn't change any columns.
Well, I know that it erroneously returns false sometimes, I'm guessing that that's the reason why.
There was a problem hiding this comment.
In any case #7072 has more details.
Imma close this PR as it adds little value keeping it open.
sminnee
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature creates an extra SELECT on every update and its
only benefit is to paper over other bugs that should be fixed
with better data integrity.
Fixes #7072