Docs for resource loading upgrade path #7076
Conversation
|
|
||
| Usage with custom logic: | ||
|
|
||
| ```php |
There was a problem hiding this comment.
I really wish we could use diff syntax here, but the underlying syntax highlighter used for docs.ss.org doesn't support it... (also: silverstripe/doc.silverstripe.org#157)
There was a problem hiding this comment.
Bah - does parsedown not support diff?
There was a problem hiding this comment.
Parsedown doesn't do syntax highlighting? We're using https://github.com/google/code-prettify as a JS lib, and that doesn't do diff: googlearchive/code-prettify#62. Ideas?
There was a problem hiding this comment.
Doh, of course. I feel like we have had this chat before, would need a separate JS lib just for diff highlighting
There was a problem hiding this comment.
highlight.js supports a large range of syntaxes, including diff - perhaps we could switch?
There was a problem hiding this comment.
| use SilverStripe\Core\Manifest\ModuleLoader; | ||
| use SilverStripe\View\ThemeResourceLoader; | ||
| $moduleFilePath = ModuleLoader::getModule('silverstripe/framework')->getRelativeResourcePath('MyFile.php'); | ||
| $baseFilePath = Director::baseFolder() . '/composer.json'; |
There was a problem hiding this comment.
Not quite sure if this is the right way to do this now? It sure beats BASE_PATH, but it's still static.
docs/en/04_Changelogs/4.0.0.md
Outdated
| $themeFolderPath = ThemeResourceLoader::inst()->getPath('simple'); | ||
| ``` | ||
|
|
||
| To ensure consistency, we've also removed support for path constants: |
There was a problem hiding this comment.
We haven't removed these.
There was a problem hiding this comment.
Replaced "removed" with "deprecated"
chillu
force-pushed
the
pulls/4.0/resource-loading-upgrade-docs
branch
from
ab17d32
to
f088ee7
Compare
docs/en/04_Changelogs/4.0.0.md
Outdated
| * `FRAMEWORK_ADMIN_DIR` and `FRAMEWORK_ADMIN_PATH` | ||
| * `FRAMEWORK_ADMIN_THIRDPARTY_DIR` and `FRAMEWORK_ADMIN_THIRDPARTY_PATH` | ||
| * `THIRDPARTY_DIR` and `THIRDPARTY_PATH` | ||
| * `ASSETS_DIR` and `ASSETS_PATH` |
There was a problem hiding this comment.
I think we have a "ASSETS_PATH" env lookup in config f or assets store configuration, but we could still deprecate it I think.
There was a problem hiding this comment.
You're right, it's too early to deprecate that - there's no appropriate getter. Which we'll need to solve, but it's out of scope of this docs-focused PR. I've removed this line
chillu
force-pushed
the
pulls/4.0/resource-loading-upgrade-docs
branch
from
f088ee7
to
2495741
Compare
See #7065