Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Fixes #7116 Improves server requirements docs viz: OpCaches. #7118

Merged
merged 1 commit into from Oct 25, 2017

Conversation

phptek
Copy link

@phptek phptek commented Jul 4, 2017

No description provided.

@kinglozzer
Copy link
Member

kinglozzer commented Jul 4, 2017

If you're using PHP >= 5.5 then Zend OpCache is installed by default in managed package repos e.g. apt

Given that, I wonder if we should just remove the suggestion of installing an opcache entirely. SS4 only supports 5.6+ anyway, so everyone will get an opcache unless they’re building from source right?

Edit: Okay, @dhensby has corrected me, we probably should keep this suggestion

@@ -12,6 +12,7 @@ Our web-based [PHP installer](installation/) can check if you meet the requireme
* Once PHP versions become [unsupported by the PHP Project](http://php.net/supported-versions.php),
we drop support for those versions in the [next minor release](/contributing/release-process). This means that PHP 5.6 support may be dropped in a 4.x minor release after December 2018.
* We recommend using a PHP accelerator or opcode cache, such as [xcache](http://xcache.lighttpd.net/) or [WinCache](http://www.iis.net/download/wincacheforphp).
* If you're using PHP >= 5.5 then [Zend OpCache](http://php.net/manual/en/book.opcache.php) is installed by default in managed package repos e.g. apt (You may need to manually enable it in php.ini). Do not try and run additional opcaches alongside Zend OpCache without first disabling it.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This definitely is not true for CentOS - I have to install it manually to get it in (yum install php-opcache)

@phptek
Copy link
Author

phptek commented Jul 4, 2017

True. But the docs for 3.x should keep this. Also note it may still be useful for those that may be lumbered with xcache and the friendly sysadmin is left scratching his head when upgrading from <5.5 to >5.5 and wondering why his devs are reporting non-app specific weird behavior..happened only about 2 months ago!

@phptek
Copy link
Author

phptek commented Jul 4, 2017

@dhensby good spot. What say this patch is modified as a side note via an asterisk, and made more general i.e "Some package managers such as apt, enable OpCache by default...." ?

@dhensby
Copy link
Contributor

dhensby commented Jul 4, 2017

@dhensby good spot. What say this patch is modified as a side note via an asterisk, and made more general i.e "Some package managers such as apt, enable OpCache by default...." ?

I don't think it has anything to do with the package manager itself, it's up to the repository you're installing from. For example it may be installed by default for Ubuntu's own repo but not for Debian's.

I'd probably be very generic here and say something to the effect of "in some cases it is installed by default and you should make sure you don't run two side-by-side as it'll have unexpected consequences"...

@phptek
Copy link
Author

phptek commented Jul 4, 2017

I have re-written things in line with the discussion so far, let me know your collective thoughts.

Copy link
Member

@kinglozzer kinglozzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dhensby
Copy link
Contributor

dhensby commented Jul 5, 2017

thanks - now, should this go in 3 branch ?

@flamerohr
Copy link
Contributor

This looks suitable for both 3 and 4, though maybe double check the PHP 5.5 for 3? :D

@flamerohr flamerohr changed the base branch from master to 4.0 October 25, 2017 20:19
@flamerohr
Copy link
Contributor

Changed to the 3.5 branch and rebased

@flamerohr
Copy link
Contributor

Merging, doc changes shouldn't affect tests :) ...I hope...

@flamerohr flamerohr merged commit a335158 into silverstripe:3.5 Oct 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants