-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: Fixes #7116 Improves server requirements docs viz: OpCaches. #7118
Conversation
Edit: Okay, @dhensby has corrected me, we probably should keep this suggestion |
@@ -12,6 +12,7 @@ Our web-based [PHP installer](installation/) can check if you meet the requireme | |||
* Once PHP versions become [unsupported by the PHP Project](http://php.net/supported-versions.php), | |||
we drop support for those versions in the [next minor release](/contributing/release-process). This means that PHP 5.6 support may be dropped in a 4.x minor release after December 2018. | |||
* We recommend using a PHP accelerator or opcode cache, such as [xcache](http://xcache.lighttpd.net/) or [WinCache](http://www.iis.net/download/wincacheforphp). | |||
* If you're using PHP >= 5.5 then [Zend OpCache](http://php.net/manual/en/book.opcache.php) is installed by default in managed package repos e.g. apt (You may need to manually enable it in php.ini). Do not try and run additional opcaches alongside Zend OpCache without first disabling it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This definitely is not true for CentOS - I have to install it manually to get it in (yum install php-opcache
)
True. But the docs for 3.x should keep this. Also note it may still be useful for those that may be lumbered with xcache and the friendly sysadmin is left scratching his head when upgrading from <5.5 to >5.5 and wondering why his devs are reporting non-app specific weird behavior..happened only about 2 months ago! |
@dhensby good spot. What say this patch is modified as a side note via an asterisk, and made more general i.e "Some package managers such as apt, enable OpCache by default...." ? |
I don't think it has anything to do with the package manager itself, it's up to the repository you're installing from. For example it may be installed by default for Ubuntu's own repo but not for Debian's. I'd probably be very generic here and say something to the effect of "in some cases it is installed by default and you should make sure you don't run two side-by-side as it'll have unexpected consequences"... |
I have re-written things in line with the discussion so far, let me know your collective thoughts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
thanks - now, should this go in 3 branch ? |
This looks suitable for both 3 and 4, though maybe double check the PHP 5.5 for 3? :D |
Changed to the |
Merging, doc changes shouldn't affect tests :) ...I hope... |
No description provided.