Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add crosslinks to lessons #7645

Merged
merged 2 commits into from Nov 28, 2017
Merged

Add crosslinks to lessons #7645

merged 2 commits into from Nov 28, 2017

Conversation

unclecheese
Copy link

Resolves #7568

@chillu chillu mentioned this pull request Nov 27, 2017
Closed
1 task
phalkunz
phalkunz suggested changes Nov 27, 2017
View reviewed changes
Copy link
Contributor

@phalkunz phalkunz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think:

docs/en/00_Getting_Started/01_Installation/index.md should have ref to:
Up and Running: Setting up a local SilverStripe dev environment

docs/en/02_Developer_Guides/01_Templates/index.md
Migrating static templates into your theme

docs/en/02_Developer_Guides/01_Templates/06_Themes.md should have ref to:
Migrating static templates into your theme

docs/en/02_Developer_Guides/02_Controllers/02_Routing.md should have ref to:
Controller Actions / DataObjects as Pages

docs/en/02_Developer_Guides/00_Model/09_Validation.md Outdated
@@ -45,6 +45,9 @@ class MyObject extends DataObject
}
```

## Related Lessons
* [The holder/page pattern](https://www.silverstripe.org/learn/lessons/v4/the-holderpage-pattern-1)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't seem relevant here.

@unclecheese
Copy link
Author

Have made those updates, @phalkunz

phalkunz
phalkunz approved these changes Nov 28, 2017
View reviewed changes
Copy link
Contributor

@phalkunz phalkunz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@flamerohr flamerohr merged commit 54689a3 into silverstripe:4.0 Nov 28, 2017
@flamerohr flamerohr deleted the pulls/4.0/hot-crosslinked-puns branch November 28, 2017 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phalkunz phalkunz phalkunz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@unclecheese @phalkunz @flamerohr