Correcting docs around summary field relabelling #7684
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although this is weird that it doesn't use the same logic and searchable fields.
tractorcow
reviewed
Dec 7, 2017
| @@ -196,9 +196,9 @@ class MyDataObject extends DataObject | |||
| ]; | |||
|
|
|||
| private static $summary_fields = [ | |||
| 'Name' => 'Name', | |||
There was a problem hiding this comment.
The old behaviour wasn't incorrect; You can use field_labels to override summary_fields, but it's not necessary to.
Did you find the previously documented API didn't actually work?
tractorcow
suggested changes
Dec 7, 2017
|
Ping @pitchandtone - keen to get this merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although this is weird that it doesn't use the same logic and searchable fields.