FIX: Gridfields with dropdowns having lots of overflow #7784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbieaverill
approved these changes
Jan 30, 2018
|
You happy with this @dhensby? |
|
We should really check this doesn't cause any regressions in our supported browsers:
|
dhensby
force-pushed
the
bugfix/gridfield-overflow
branch
from
565693c
to
7384e3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the issue with how css overflows work here, the original fix for overflowing gridfields causes scrollable gridfields when used in conjunction with dropdowns. This change targets more specifically the areas of gridfield which caused the issue shown here
Before:
After (no scrollbar):
Tested on Chrome