FIX: Don't auto-generate indexes for Text field types (fixes #7900) #7945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhensby
reviewed
Mar 21, 2018
model/DataObject.php
Outdated
| if ( | ||
| $this->hasOwnTableDatabaseField($column) | ||
| && !array_key_exists($column, $indexes) | ||
| && $fieldType !== 'Text' && !is_subclass_of($fieldType, 'Text') |
There was a problem hiding this comment.
I'd prefer a less hard-coded approach here, where we can set a config list of blacklisted index types?
There was a problem hiding this comment.
Yeah sure. Do you think DataObject makes sense, or should it be a setting like DBField.auto_indexable and then set private static $auto_indexable = false; on Text?
There was a problem hiding this comment.
oooh, I like the latter idea 👍
kinglozzer
force-pushed
the
indexual-healing
branch
3 times, most recently
from
ba8e47f
to
ce3751d
Compare
|
Ping @dhensby |
dhensby
suggested changes
Apr 9, 2018
model/DataObject.php
Outdated
| @@ -3421,7 +3421,15 @@ public function databaseIndexes() { | |||
| continue; | |||
| } | |||
|
|
|||
| if ($this->hasOwnTableDatabaseField($column) && !array_key_exists($column, $indexes)) { | |||
| list($fieldType) = Object::parse_class_spec($this->db($column)); | |||
kinglozzer
force-pushed
the
indexual-healing
branch
from
ce3751d
to
ebd3fb6
Compare
dhensby
approved these changes
Apr 9, 2018
|
merge on green |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7900