BUG Prevent password validator min score producing false negatives #8013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbieaverill
approved these changes
Apr 17, 2018
|
OK - I assume this is a bug in 4.0 as well as 4.1, can we target 4.0 whilst it's still a supported version? |
|
Actually 4.0 is safe; We'd refactored PasswordValidator in 4.1, introducing the bug there. |
dhensby
approved these changes
Apr 18, 2018
|
Yeah after I looked at this I realised my error. One is the list of all available tests, the other is the list of all enabled tests. The reason they are separate was correct and intentional. |
|
@dhensby Are you happy to merge this? |
|
I am, but does it fully address the initial bug? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #7995
Fixes min score failing if no tests are set
Fixes min score failing if there are no failing tests
Adds unit tests to cover the above
Fix up bad phpdoc, code style, linting, and upgrade deprecated API usage