Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG Prevent canonical URL causing a redirect on CLI unless explicitly enabled #8158

Merged
merged 1 commit into from Jun 11, 2018
Merged

BUG Prevent canonical URL causing a redirect on CLI unless explicitly enabled #8158

merged 1 commit into from Jun 11, 2018

Conversation

tractorcow
Copy link
Contributor

Replaces #8157

Should automatically respect the setEnabledEnvs(true) in tests, meaning these continue to work as expected when testing, even on CLI.

@tractorcow tractorcow mentioned this pull request Jun 11, 2018
Closed
robbieaverill
robbieaverill approved these changes Jun 11, 2018
View reviewed changes
Copy link
Contributor

@robbieaverill robbieaverill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. I feel like the Director::is_cli() check is the important part, but can see that without the enabled environments check this would be impossible to unit test, so all good.

@robbieaverill robbieaverill merged commit f256045 into silverstripe:4.0 Jun 11, 2018
@tractorcow tractorcow deleted the pulls/4.0/fix-cli-canonical-middleware branch June 12, 2018 21:38
@robbieaverill robbieaverill mentioned this pull request Jun 13, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robbieaverill robbieaverill robbieaverill approved these changes

Assignees
No one assigned
Labels
affects/v4 type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tractorcow @robbieaverill