WIP: Update $odd logic, instanceof instead of is_a and remove SQLMap checks #8266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SQLMap was removed early in 3.x, so no need to keep the checks around for it. This commit also improves the logic in CheckboxSetField very slightly.
|
I'm happy - just wondering if this is worthy of going into a sec-only release line? |
|
It could go anywhere really, I can re-target at 4.x if you'd rather? |
|
yes please |
robbieaverill
changed the title
|
Ok, these changes have already been refactored in SilverStripe 4.1 so I'll just close this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SQLMap was removed early in 3.x, so no need to keep the checks around for it.
This commit also improves the logic in CheckboxSetField very slightly.
Some minor updates to the code.