3.7 HTTP Caching fixes #8318
Merged
3.7 HTTP Caching fixes #8318
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinglozzer
requested changes
Aug 13, 2018
control/HTTPCacheControl.php
Outdated
| @@ -358,8 +358,6 @@ public function privateCache($force = false) | |||
| // Update the directives | |||
| $this->setDirective('private'); | |||
| $this->removeDirective('public'); | |||
| $this->removeDirective('no-cache'); | |||
| $this->removeDirective('no-store'); | |||
There was a problem hiding this comment.
Upon reflection I think these should stay. Reading through the docblock this looks like the intended behaviour, I just think I was thrown off by the method name - maybe enablePrivateCache() and enablePublicCache() would be more descriptive names?
There was a problem hiding this comment.
ok - I'm on the fence about this too and I think the likelihood of users making manually disabling caching and then calling privateCache() is low.
I'll remove this change and we can see how it goes without it.
dhensby
force-pushed
the
pulls/3.7/fix-http-caching
branch
from
9a5fa5c
to
362c2f3
Compare
kinglozzer
approved these changes
Aug 13, 2018
chillu
added a commit
to open-sausages/silverstripe-framework
that referenced
this pull request
Sep 4, 2018
Original author: @dhensby Forward port from 3.7 fix at silverstripe#8318
chillu
added a commit
to open-sausages/silverstripe-admin
that referenced
this pull request
Sep 4, 2018
Original author: @dhensby Forward port from 3.7 fix at silverstripe/silverstripe-framework#8318
chillu
added a commit
to open-sausages/silverstripe-framework
that referenced
this pull request
Sep 4, 2018
Original author: @dhensby Forward port from 3.7 fix at silverstripe#8318
chillu
added a commit
to open-sausages/silverstripe-admin
that referenced
this pull request
Sep 4, 2018
Original author: @dhensby Forward port from 3.7 fix at silverstripe/silverstripe-framework#8318
This was referenced Sep 4, 2018
|
We should do a 3.7 release soon with this fix in |
|
It is imminent |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8289
LeftAndMainwill disable HTTP CachingStopsprivateCachefrom removing current state (disabled, etc).