API Rename resources to _resources #8364
Conversation
|
To discuss:
|
| @@ -55,8 +55,8 @@ protected function error($message = null) | |||
| protected function installHeader() | |||
| { | |||
| $clientPath = PUBLIC_DIR | |||
| ? 'resources/vendor/silverstripe/framework/src/Dev/Install/client' | |||
| : 'resources/silverstripe/framework/src/Dev/Install/client'; | |||
| ? '_resources/vendor/silverstripe/framework/src/Dev/Install/client' | |||
There was a problem hiding this comment.
Why not use the constant for these bits?
I don't see how this wouldn't be a breaking API change :( .
+1 for making this name configurable in 5.x. Can we do some composer.json configuration to make that work? |
|
I tend to agree with @ScopeyNZ. This will be very disruptive to our module ecosystem. Can we not do this but just make it configurable at the project level from SS5 on? |
|
Looks like we'll need to soft-code it. If it's not configured, it'll need to default to |
|
#8364 should supersede this PR I think. Unless someone has objections, I'll close this one. |
|
Closing in favour of #8519 |
Fixes #7932
Requires silverstripe/vendor-plugin#25
Also all other modules will need to have their vendor-plugin dependency bumped to ^2 as well. My suggestion is to get the module merged first and migrate the modules one at a time.