Removed SS_CONFIGSTATICMANIFEST #8372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbieaverill
approved these changes
Sep 10, 2018
There was a problem hiding this comment.
Thanks. I'm not that familiar with this code, but I can see that it the reflection changes were introduced in an early 4.0 alpha release, and the manifest itself was removed in favour of the silverstripe/config module.
I too can't find any reference to why this environment variable would do anything in the current context (SS 4.2).
Thank you!
|
You are welcome! Thanks for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct me if I'm wrong, but it seems as if the .env property
SS_CONFIGSTATICMANIFESTis not used.