New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix search filtering relations and clear filters #8477
Fix search filtering relations and clear filters #8477
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tried it but the changes LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still getting some problems clearing filters however the relation seems to work.
I've got a PR for Framework test that makes those edge cases easier to test silverstripe/silverstripe-frameworktest#55 |
080ab4f
to
eb69624
Compare
eb69624
to
0531e2f
Compare
0531e2f
to
f498746
Compare
Fixes silverstripe/silverstripe-admin#668 and fixes silverstripe/silverstripe-admin#672