Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix search filtering relations and clear filters #8477

Merged

Conversation

lukereative
Copy link

@lukereative lukereative commented Oct 15, 2018

Copy link
Contributor

@robbieaverill robbieaverill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tried it but the changes LGTM

Copy link
Contributor

@maxime-rainville maxime-rainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still getting some problems clearing filters however the relation seems to work.

https://youtu.be/bM62FrtutAY

@maxime-rainville
Copy link
Contributor

I've got a PR for Framework test that makes those edge cases easier to test silverstripe/silverstripe-frameworktest#55

@unclecheese unclecheese merged commit 3284bf4 into silverstripe:4.3 Oct 26, 2018
@unclecheese unclecheese deleted the pulls/4/5-roll-refined-search branch October 26, 2018 01:44
bergice pushed a commit to open-sausages/silverstripe-framework that referenced this pull request Nov 5, 2018
unclecheese pushed a commit to open-sausages/silverstripe-framework that referenced this pull request Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants