FIX DataObject singleton creation #8516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unclecheese
reviewed
Oct 24, 2018
unclecheese
previously requested changes
Oct 24, 2018
|
Tentatively marking as 4.3, assuming it's nearly over the line. This is the issue where every first dev build on a migrated data set fails in certain situations, making for a pretty crap onboarding experience to our platforms, right? |
|
@unclecheese @chillu if this is merged to the 4.1 branch today, will it make it into the 4.3 release? Or should I rebase this to a different branch? |
unclecheese
approved these changes
Oct 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure DataObject instances are aware they are singletons so functions like populateDefaults() can be skipped. (fixes #4878)
Correctly applies #7850 to the 4.x line
This has already been fixed in 3.x