Persist GridField readonly state, add view button #8535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
unclecheese
requested changes
Oct 30, 2018
src/Forms/GridField/GridField.php
Outdated
| } | ||
| } | ||
|
|
||
| // As the edit button may have been removed, add a view button if it doesn't have one | ||
| if ($copyConfig->getComponentsByType(GridFieldViewButton::class)->count() === 0) { |
There was a problem hiding this comment.
Better expressed as if (!$copyConfig->getComponentByType(...))
There was a problem hiding this comment.
Got it mixed up with removeComponentsByType which only has a multiple selector method, I've now changed it to the singular.
src/Forms/GridField/GridField.php
Outdated
| @@ -1009,6 +1029,9 @@ public function gridFieldAlterAction($data, $form, HTTPRequest $request) | |||
| } | |||
|
|
|||
| if ($request->getHeader('X-Pjax') === 'CurrentField') { | |||
| if ($this->getState(true)->Readonly) { | |||
There was a problem hiding this comment.
true is the default value. This can just be getState()
src/Forms/GridField/GridField.php
Outdated
| public function setReadonly($readonly) | ||
| { | ||
| parent::setReadonly($readonly); | ||
| $this->getState()->Readonly($readonly); |
There was a problem hiding this comment.
Wondering, only because this is so ugly and IDE unfriendly, is this functionally equivalent to just getState()->Readonly = $readonly? I think it's just a question of whether it uses __call() or __set().
unclecheese
approved these changes
Oct 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3357 (remaining ACs/bugs)