Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 02_Images.md #8653

Merged
merged 1 commit into from Dec 2, 2018
Merged

Update 02_Images.md #8653

merged 1 commit into from Dec 2, 2018

Conversation

ghost
Copy link

@ghost ghost commented Dec 1, 2018

If the default is that resampling is off, shouldn't the example be that force_resample is set to true to enable resample?

Thanks for contributing, you're awesome! ⭐
Please describe expected and observed behaviour, and what you're fixing.
For visual fixes, please include tested browsers and screenshots.
Search for related existing issues and link to them if possible.
Please read https://docs.silverstripe.org/en/contributing/code/

If the default is that resampling is off, shouldn't the example be that force_resample is set to true to enable resample?
Copy link
Contributor

@robbieaverill robbieaverill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants