FIX: prevent shortcodeparser warnings when sitetree link includes anchors or querystrings #8667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the chance of getting a unit test for this? 😛 |
|
FYI this was originally raise against SilverStripe 3 at #8649 |
robbieaverill
force-pushed
the
patch-3
branch
from
6c62322
to
d116b9a
Compare
robbieaverill
approved these changes
Jan 29, 2019
There was a problem hiding this comment.
I've added a test for this and switched the target to the 4.0 branch. Merge on green - thanks @mikeyc7m !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a sitetree link contains an anchor or querystring, such as
<a href="[sitetree_link,id=1]?my-string=this&thing=2#my-anchor">Link</a>the shortcodeparser chokes. This is a simple fix.Prevents this death message: