Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update nginx example to support assets better #8818

Merged
merged 1 commit into from
Feb 28, 2019
Merged

Update nginx example to support assets better #8818

merged 1 commit into from
Feb 28, 2019

Conversation

oddnoc
Copy link
Contributor

@oddnoc oddnoc commented Feb 21, 2019

  • Enable viewing of draft assets
  • Disable viewing of .htaccess and .method
  • Enforce File.allowed_extensions (manually for now)

Fixes #8579

Update nginx example to support assets better
22ae0e4 
- Enable viewing of draft assets
- Disable viewing of .htaccess and .method
- Enforce File.allowed_extensions (manually for now)
@robbieaverill
Copy link
Contributor

Related: #8579

Any thoughts on how this PR relates to that one? Should we close #8579?

@oddnoc
Copy link
Contributor Author

oddnoc commented Feb 23, 2019

Related: #8579

Any thoughts on how this PR relates to that one? Should we close #8579?

I think this change addresses #8579 and it can be closed, unless @simonwinter objects.

@simonwinter
Copy link
Contributor

@oddnoc @robbieaverill - by all means close #8579

robbieaverill
robbieaverill approved these changes Feb 28, 2019
View reviewed changes
Copy link
Contributor

@robbieaverill robbieaverill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. I haven't tested this configuration in practice, but I think it's likely that it's come from a real world example.

@robbieaverill robbieaverill merged commit 8af1ca5 into silverstripe:4 Feb 28, 2019
@robbieaverill robbieaverill mentioned this pull request Feb 28, 2019
Closed
@oddnoc oddnoc deleted the 8579-nginx-assets branch March 4, 2019 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robbieaverill robbieaverill robbieaverill approved these changes

Assignees
No one assigned
Labels
affects/v4 type/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oddnoc @robbieaverill @simonwinter