-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG Renable the ability to do dynamic assignment with DBField #8821
BUG Renable the ability to do dynamic assignment with DBField #8821
Conversation
@robbieaverill All your points have been addressed. |
Actually SQLite and Postgress don't like my test. I'll have another go at it. |
…amic DBFIeld assigment
} | ||
|
||
/** | ||
* @expectedException PHPUnit_Framework_Error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yeah - user errors 😆
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still some super minor things like return types (e.g. mixed) not needing to be there, and double vs single quotes in the test dataobject, but nothing that blocks merge. Merge on green 👍
This partially restores the ability for DBField classes to do dynamic assignment if scalarValueOnly is false.
Parent issue