Commenting out the PR template #8967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you!! Haha 😆 |
robbieaverill
approved these changes
May 8, 2019
|
Want to retarget at a patch branch so it can be merged up? |
…ault This works as Markdown is just augmented raw HTML
ScopeyNZ
force-pushed
the
pulls/master/comment-pr-template
branch
from
c8199f9
to
c2d69a3
Compare
|
I've rebased onto
It's only worth merging up to master then :) |
dnsl48
approved these changes
May 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an idea for a slight improvement to our PR template. Considering that we intend for the author to delete the PR template (it's just a message) we can just comment it out (HTML style) and if they accidentally leave it in it won't be shown.
As POC, I haven't touched the PR template for this PR. Contributors can see it by attempting to edit my message.