Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move test to autoload-dev #9038

Closed
wants to merge 1 commit into from
Closed

Move test to autoload-dev #9038

wants to merge 1 commit into from

Conversation

szepeviktor
Copy link
Contributor

...in composer config

...in composer config
@robbieaverill
Copy link
Contributor

From memory this was deliberate, as autoload dev is a project level setting so would mean modules installed wouldn’t have their test classes auto loaded. I’m happy to be corrected!

@szepeviktor
Copy link
Contributor Author

szepeviktor commented Jun 3, 2019

I agree:

  • if you use the framework as a project (in development) you run tests
  • if you install it as a dependency you never run tests

What do you think?

@robbieaverill
Copy link
Contributor

That's not usually how SilverStripe is installed - we install one of the three core recipes: silverstripe/installer, silverstripe/recipe-cms or silverstripe/recipe-core. During Travis builds we install the repository as a project and run its tests, but those recipes are examples of "real world" installations where modules such as framework are installed in vendor/silverstripe/* and have suites of tests run against them. At this stage I don't think we'll be looking to change that architecture. Thanks for the PR though!

@szepeviktor
Copy link
Contributor Author

Okay, I see.

@szepeviktor szepeviktor deleted the patch-1 branch June 3, 2019 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants