Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Include attributes in FormField schema data (fixes #9124) #9125

Closed
wants to merge 1 commit into from
Closed

FIX: Include attributes in FormField schema data (fixes #9124) #9125

wants to merge 1 commit into from

Conversation

kinglozzer
Copy link
Member

No description provided.

@robbieaverill
Copy link
Contributor

I'm a little nervous about this change, because I feel like there are some modules where we've added getSchemaData() into getAttributes(), probably for the same reason. If my suspicion is correct, merging this would create a circular reference.

@kinglozzer
Copy link
Member Author

Yeah you’re right - TreeDropdownField does exactly that

@kinglozzer kinglozzer closed this Jul 15, 2019
@kinglozzer kinglozzer mentioned this pull request Jul 15, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
affects/v4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kinglozzer @robbieaverill