Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS Update SilverStripe Contributing Code GitHub labels #9303

Merged
merged 1 commit into from Nov 14, 2019

Conversation

sachajudd
Copy link
Contributor

Suggested updates to SilverStripe CMS GitHub labels:
Note: I've created this pull request on behalf of @newleeland & @clarkepaul's work. cc @silverstripeux

Problem:
When reviewing the labels applied to both Type/UX and non-Type/UX issues they seem to be weighted quite differently, most noticeably when the phase “Workarounds” is used.

Example: When a CMS user has an alternative way to accomplish a task the label is often marked as Impact low (e.g. breadcrumbs don’t work as expected), because a user could choose to navigate the UI without using the breadcrumbs. The problem with this is that breadcrumbs might be the main way they intend to navigate and not be aware of alternatives. Breadcrumbs are a prominent feature of the UI, used in every view. When they don’t look or function correctly it is going to be very obvious to users that something is wrong, this can have a long term effect on how reliable they perceive our CMS to be and how confident they are with how we will manage their content and customer details.

  • Enhancement label is not covered in the classifications
  • Bug label is not covered (maybe this doesn't need to be?)

Proposed solution:

  • Make it clearer that the labels are incorporating both tech functionality and end-user functionality.
  • Add a definition of an enhancement
  • Enhancements can be combined with the Impact rating and still make sense in that context
  • Add definition of a bug

Copy link
Contributor

@dnsl48 dnsl48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. Impacts how we triage issues /cc @silverstripe/core-team

@maxime-rainville
Copy link
Contributor

@silverstripe/core-team

docs/en/05_Contributing/01_Code.md Outdated Show resolved Hide resolved
docs/en/05_Contributing/01_Code.md Outdated Show resolved Hide resolved
@robbieaverill robbieaverill merged commit 022abd8 into silverstripe:4 Nov 14, 2019
@sachajudd sachajudd deleted the docs/impact-ratings branch November 14, 2019 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants