Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG FormAction title property cannot be set if useButtonTag is false #9305

Merged
merged 1 commit into from Nov 14, 2019

Conversation

tractorcow
Copy link
Contributor

I was trying to set a title property for my form action, then noticed the code wouldn't let you set it at all unless using a button tag.

This changes description to override title, but only if description is set to a non-empty value.

Copy link
Contributor

@robbieaverill robbieaverill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robbieaverill robbieaverill merged commit bd658ca into silverstripe:4.3 Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants