Fix PHP versions in upgrade guide #9350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make versions less generic, and add note about following PHP's supported versions guide
robbieaverill
approved these changes
Dec 9, 2019
|
Ah yeah sorry, did that via the web interface which isn't clear about where it's going to create the branch (I didn't realise I had write access to the origin 🤦♂). I have been given the waggly finger by @chillu so I feel suitably chastised 🙇 |
|
It's not your fault that GitHub gives you the footgun and forces you to use it (instead of defaulting to creating the branch on your fork) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make versions less generic, and add note about following PHP's supported versions guide