Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Ensure realpath returns a string for stripos #9471

Merged
merged 1 commit into from Apr 19, 2020

Conversation

mattclegg
Copy link
Contributor

I have this error appear in php 7.4;

[Deprecated] stripos(): Non-string needles will be interpreted as strings in the future. Use an explicit chr() call to preserve the current behavior

Updating the realpath to return a string fixes the issue.

Any feedback welcome.

src/Core/Manifest/ModuleManifest.php Outdated Show resolved Hide resolved
[Deprecated] stripos(): Non-string needles will be interpreted as strings in the future. Use an explicit chr() call to preserve the current behavior
@dhensby dhensby merged commit 99b63b6 into silverstripe:4.5 Apr 19, 2020
@dhensby
Copy link
Contributor

dhensby commented Apr 19, 2020

thanks

@mattclegg mattclegg deleted the 1587213647 branch April 19, 2020 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants