Update DefaultAdminService.php #9487
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[link](#9475 (comment)) I did some changes to the SilverStripe code to fix the use of "unique_identifier_field" variabile. Now you can set any variable name, which will be used for login and will also be set as the required field in Member_Validator
|
Hey @alessandromarotta, Can you please raise an issue so that the merits of this change can be discussed before we proceed? Additionally, can you please group these changes into a single Pull Request? None of these PRs can be merged on their own, and it's very difficult to review the full set of changes when they're spread out this way. See our contributing guide for details on how to get a local installation of Silverstripe running so that you can test your changes before pushing up a PR. |
This was referenced Apr 22, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
link
I did some changes to the SilverStripe code to fix the use of "unique_identifier_field" variabile.
Now you can set any variable name, which will be used for login and will also be set as the required field in Member_Validator