BUGFIX: ensure template file exists

[mattclegg]

When a .ss file is removed from the theme and the cache is not cleared then I receive the error; filemtime(): stat failed for MyTemplate.ss ref SSViewer.php on line 636.

Does it make sense to check if the file exists before running filemtime to avoid the problem again?

Any feedback welcome.

[dhensby]

Sure, something like this makes sense, but it also seems there needs to be a more thorough handling of missing template files.

Fixing this particular notice would then just mean the template rendered unexpectedly from the cache, right?

This change needs to more thoroughly handle this error case and we probably needs some test coverage as well as agreed handling for this. Should we have a helpful error, for example, like "template not found" or should this kick off a flush of the template cache?

[mattclegg]

Yeah, this is just hiding the problem really but personally I'd rather they see stale file cache when a user is accessing the website than they see a PHP Warning.

[dhensby]

No one will see a php warning because warnings aren't displayed in prod

[mattclegg]

That's true. Do you think it would be better to raise "template not found" as a warning when filemtime fails?

[dhensby]

I think that makes sense - we could report a warning if the template doesn't exist and we can give a more helpful warning too: Could not find template "%s"; you may need to flush the cache

[emteknetnz]

This pull request hasn't had any activity for a while. Are you going to be doing further work on it, or would you prefer to close it now?

[emteknetnz]

It seems like there's going to be no further activity on this pull request, so we've closed it for now. Please open a new pull-request if you want to re-approach this work, or for anything else you think could be fixed or improved.