Deprecation cleanup #951
Merged
Deprecation cleanup #951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
November 15, 2012 14:43
Use the methods param() and params() on SS_HTTPRequest instead.
Director::redirect() -> Controller->redirect() Director::redirect_to() -> Controller->redirectedTo() Director::set_status_code() -> Controller->getResponse()->setStatusCode() Director::get_status_code() -> Controller->getResponse()->getStatusCode() Director::redirectBack() -> Controller->redirectBack()
Use SS_ENVIRONMENT_TYPE in your _ss_environment.php file, or Director::set_environment_type()
Use the individual getters on PaginatedList instead.
Use Upload_Validator instead.
Use FormAction with setAttribute('src', 'myimage.png') and custom
JavaScript to achieve hover effect.
Use UploadField with
a$myField->getValidator()->setAllowedExtensions(array('jpg', 'gif', 'png'))
Use ArrayData::toMap() instead
Use $member->addToGroupByCode($groupcode) instead
Use PasswordEncryptor::check() instead
Use Zend_Translate instead.
Use LowerCase() and UpperCase() instead
Use custom Javascript validation instead
added 21 commits
November 15, 2012 14:43
Use setRightTitle() and setFolderName() instead
Use FieldList API through Form::Fields() and Form::Actions() instead
Use SecurityToken class directly instead
Use leftJoin() or innerJoin() instead
Use 2 arguments, the first being limit and the second offset instead.
This is not used internally any longer
Use DataList API instead
Use DataList API instead
…elds() Use database_fields() and custom_database_fields() instead
setTabIndex() -> setAttribute('tabindex')
getTabIndex() -> getAttribute('tabindex')
describe() -> setDescription()
Use setColumns() and setRows() instead
Use setColumns() and setRows() instead
Use ToggleCompositeField->setStartClosed() instead
GridField uses createTag() which is marked for deprecation, rather than have it used as the cornerstone of generating FormField templates, use it as a helper in case fields generate HTML tags from PHP.
|
Legend! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing all the deprecated 2.4/2.5/3.0 things.
CMS pull request: silverstripe/silverstripe-cms#239 (please pull that one after this)
Unit tests will probably fail as a result, since the CMS pull request doesn't get tested on Travis with the dependent framework changes here.